[SA-exim] SAaddSAEheaderBeforeSA ignored

[Daniel Dadap]

Hello,

I was trying to disable SAaddSAEheaderBeforeSA in sa-exim.conf, but no
matter what I did, I was still getting unwanted headers in all my
messages.

I took a quick look at the source, and noticed the following:

if(SAaddSAEheaderBeforeSA)
{
AddSAEheaders((char *)rcptlist, SAmaxrcptlistlength);
}

... and a little bit later...

if(!SAaddSAEheaderBeforeSA)
{
AddSAEheaders((char *)rcptlist, SAmaxrcptlistlength);
}

This doesn't seem intentional. I removed the ! from the second check,
and setting SAaddSAEheaderBeforeSA worked as intended. I didn't read the
code closely enough to know whether it's actually necessary to check in
both places, so the attached patch only removes the negation and doesn't
make any attempt to do anything else.

It's entirely possible that the ! is intentional, and that I've
misunderstood the intended operation of the program, but I'm going to
leave my sa-exim patched like this, because it finally works the way I
want it to. :)

Regards,

Daniel Dadap

[Richard Lithvall]

Post by Daniel Dadap
Hello,
I was trying to disable SAaddSAEheaderBeforeSA in sa-exim.conf, but no
matter what I did, I was still getting unwanted headers in all my
messages.
if(SAaddSAEheaderBeforeSA)
{
AddSAEheaders((char *)rcptlist, SAmaxrcptlistlength);
}
... and a little bit later...
if(!SAaddSAEheaderBeforeSA)
{
AddSAEheaders((char *)rcptlist, SAmaxrcptlistlength);
}
This doesn't seem intentional.

It is intentional. I think you have misunderstood the purpose of this option:

[Daniel Dadap]

Post by Daniel Dadap
Hello,
I was trying to disable SAaddSAEheaderBeforeSA in sa-exim.conf, but no
matter what I did, I was still getting unwanted headers in all my
messages.
if(SAaddSAEheaderBeforeSA)
{
AddSAEheaders((char *)rcptlist, SAmaxrcptlistlength);
}
... and a little bit later...
if(!SAaddSAEheaderBeforeSA)
{
AddSAEheaders((char *)rcptlist, SAmaxrcptlistlength);
}
This doesn't seem intentional.